<html>
<head><meta charset="utf-8"><title>review scheduling? · t-lang/doc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/index.html">t-lang/doc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html">review scheduling?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="203140035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203140035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203140035">(Jul 07 2020 at 18:21)</a>:</h4>
<p>I was wondering if it would help if people could commit to a regular time for discussing and reviewing reference PRs, perhaps something like 30 minutes a week? This could either be synchronous or asynchronous. I am overwhelmed with reviews across all my projects, and just realized its been almost 3 weeks since I looked at some of these PRs. Many are stuck waiting for more knowledgeable people to look at. Some are stuck for various other reasons.</p>
<p>Some that could use help:</p>
<p><a href="https://github.com/rust-lang/reference/pull/834">https://github.com/rust-lang/reference/pull/834</a> — Waiting for t-lang to decide if a commitment of usize/isize is at least 16-bits is a reasonable assertion.</p>
<p><a href="https://github.com/rust-lang/reference/pull/841">https://github.com/rust-lang/reference/pull/841</a> — Monomorphization and statics. Seems reasonable, but I do not know if this is always true.</p>
<p><a href="https://github.com/rust-lang/reference/pull/837">https://github.com/rust-lang/reference/pull/837</a> — Could use another opinion on the exact wording.</p>
<p><a href="https://github.com/rust-lang/reference/pull/843">https://github.com/rust-lang/reference/pull/843</a> — Needs review by someone more knowledgeable than me.</p>
<p>(or really, any of the 27 open PRs)</p>



<a name="203140343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203140343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203140343">(Jul 07 2020 at 18:24)</a>:</h4>
<blockquote>
<p>Monomorphization and statics. Seems reasonable, but I do not know if this is always true.</p>
</blockquote>
<p>Statics can <strong>never</strong> be generic. It is impossible to guarantee for generic things that they are not duplicated across codegen units/crates and statics are not allowed to be duplicated.</p>



<a name="203140830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203140830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203140830">(Jul 07 2020 at 18:28)</a>:</h4>
<blockquote>
<p>Waiting for t-lang to decide if a commitment of usize/isize is at least 16-bits is a reasonable assertion.</p>
</blockquote>
<p>A system with 8bit pointers is basically unusable for anything more high-level than assembly.</p>



<a name="203141829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203141829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203141829">(Jul 07 2020 at 18:36)</a>:</h4>
<p><span class="user-mention" data-user-id="133247">@bjorn3</span> regarding statics, do you think it makes sense to explicitly state (as the PR does) that even in a generic item, statics are never duplicated?  I never really considered it, but I can see how there is a bit of ambiguity.  I guess what I'm asking, are you agreeing with the PR?  Or are you saying it is redundant?</p>



<a name="203142124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203142124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203142124">(Jul 07 2020 at 18:39)</a>:</h4>
<p>I don't think it is redundant to state that statics are never duplicated.</p>



<a name="203142247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203142247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203142247">(Jul 07 2020 at 18:40)</a>:</h4>
<p>It could say that because of this statics defined in a generic scope are pulled out of it to prevent monomorphization from duplication them. (or something like that)</p>



<a name="203143415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203143415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203143415">(Jul 07 2020 at 18:49)</a>:</h4>
<p><span class="user-mention" data-user-id="120518">@Eric Huss</span> What's the process for reviewing? Would it be appropriate for someone on the lang team to r+ something on the reference (does it use bors?), or should (and can) we use rfcbot to gauge consensus, or should we just leave a review?</p>



<a name="203143576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203143576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203143576">(Jul 07 2020 at 18:50)</a>:</h4>
<p>Also, I would be <em>happy</em> to see wg-reference reviews in either a triage meeting or design meeting. Perhaps we could use one of the upcoming design meeting slots (e.g. July 15) to process some of the backlog?</p>



<a name="203146998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203146998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203146998">(Jul 07 2020 at 19:13)</a>:</h4>
<p>The process historically has been wg-grammar members would review and merge. There is no bors.  Do you have write access to the repo?  If not, I'd like to fix that.  I'd prefer to use bors and give all of t-lang permission, but that will require help from infra.  As for consensus building, there hasn't been anything formal (except for extremely rare cases like <a href="https://github.com/rust-lang/rust/issues/71033">https://github.com/rust-lang/rust/issues/71033</a>).  Maybe rfcbot would be a good idea?  I'm reluctant to add more process, though.  </p>
<p>For now, just doing normal GitHub reviews should be fine.  If you can't click merge, I can do that until we fix permissions (unless I am the author).</p>



<a name="203195643"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203195643" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203195643">(Jul 07 2020 at 20:01)</a>:</h4>
<p><span class="user-mention" data-user-id="120518">@Eric Huss</span> I wasn't looking to request any change to the process; I was just asking what the process is. :)</p>



<a name="203195812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/203195812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#203195812">(Jul 07 2020 at 20:02)</a>:</h4>
<p>And it appears that everyone on the lang team has admin permissions on that repo.</p>



<a name="205169326"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/205169326" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#205169326">(Jul 27 2020 at 21:16)</a>:</h4>
<p><span class="user-mention" data-user-id="120518">@Eric Huss</span> hmm so -- one thing I can do is to adjust our lang team sync</p>



<a name="205169344"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/205169344" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#205169344">(Jul 27 2020 at 21:17)</a>:</h4>
<p>in particular I don't think our current searches will find issues from the reference repo</p>



<a name="205169383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/205169383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#205169383">(Jul 27 2020 at 21:17)</a>:</h4>
<p>so e.g. we can't handle nominations</p>



<a name="205169411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/review%20scheduling%3F/near/205169411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/review.20scheduling.3F.html#205169411">(Jul 27 2020 at 21:17)</a>:</h4>
<p>also, if you want to assign PRs to me, I will do my best to review them, though I'm currently on a bit of a bender due to various short term obligations</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>